Skip to content

Fix some sig/slot connections related to angle selector refactor, fixing bezier snapping

R. B. requested to merge tomtomtom/krita:tomtomtom/fixslots into master

BUG: 431336

I noticed going through tools in Krita 5 that there are some warnings about sig/slot connections being outputted to terminal. The connections for the Bezier tools were faulty as the types were mismatched, causing breakage in the snapping functionality, so those were fixed. I also removed a seemingly leftover connection for the Calligraphy tool.

The Bezier snapping bug doesn't occur in Krita 4. If you're curious why, the commit for Krita 5 had a typo while the commit for Krita 4 didn't.

Test Plan

Confirm snapping works again in the Bezier tools. Confirm there's no breakage in Calligraphy's angle usage.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports