Skip to content

435474 407921 OpenColorIO: upgrade to VFX CY 2022

Amy spark requested to merge lsegovia/krita:work/amyspark/ocio2 into master

This MR upgrades our rendering pipeline to OpenColorIO v2. The main difference is that v2 now provides the app with all the texture and uniform data, so now the binding and setting is done by the LUT docker.

This MR also adds a safety catch to prevent an OCIO parsing failure from taking our canvas down, and a workaround of Natron that allows non-English systems to correctly parse LUTs (hence almost completely preventing any occurrence of the former).

I tested it with some of the Netflix AVIF images and Dmitry's OCIO config repository, under Manjaro and Windows 10. The relevant updates have been made to 3rdparty, and tested with MinGW and MSVC.

BUG: 435474

BUG: 407921

TODO

  • Check dependency builds across Windows and Linux
  • Compatibility with VFX Platform
    • CY *-2020
      • Set up a parallel code path to initialize LUT, bind texture, etc.
      • Preserve the OCIOMain (shader function) signature
    • CY 2021
      • Migrate to the new OpenColorIO v2 API, which gets rid of the item above
      • Preserve the OCIOMain (shader function) signature
    • CY 2022
      • Set 3rdparty up (tested on Windows and Linux)
      • Ask Iván for a M1 build
      • Migrate to the new OCIOMain (shader function) signature
      • Implement new LUT/uniform handling by porting the OpenGL app helpers (WIP)

Test Plan

Build Krita. Open an AVIF HDR image with OCIO enabled. Check that the result matches stable Krita.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Amy spark

Merge request reports