Skip to content

Fix Split Strokes sig/slot connection for Cumulative Undo

R. B. requested to merge tomtomtom/krita:tomtomtom/undosig into master

The Cumulative Undo feature reintroduced in 5.1 has a faulty sig/slot connection for the Split Strokes setting, so that it wouldn't properly read and write the setting if configured. This commit should fix that issue.

Test Plan

Enable Cumulative Undo in the Undo History docker, confirm that Split Strokes is being read and written properly by configuring it, rechecking the settings, and confirming the proper behavior by testing the amount of last strokes that Krita stores separately.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by R. B.

Merge request reports