Skip to content

Bugfix: Don't disable undo/redo actions

Sharaf Zaman requested to merge szaman/krita:bug-443188-undo-operations into master

The intermediate actions (like that of transform tools) don't create an undo action on primary undo stack which leaves undo action as disabled until the KisActionManager::updateGUI is triggered which re-enables the actions.

The better solution seems to be to keep the undo disabled if there is nothing on undo stack, but this will create problems because some tools have a non-global-undo-stack.

Test Plan

BUG:443188

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports