Skip to content

Add hold last frame option in recorder docker export dialog

reinold rojas requested to merge reinoldrojas/krita:reinoldrojas/recorder-hold-last-frame into master

In the Recorder docker export dialog add a "Hold Last frame" option to repeat the last frame for a user defined amount of seconds on export. Useful for you/viewers to actually see the completed work at the end of the video instead of the video ending immediately. Defaults to 5 seconds 2021-10-08_16-58

The default "render as" profiles have been edited to support the new option. If repeating the last frame is undesired then setting "Hold Last Frame" to 0 adds no additional frames.

BUG:441184

Test Plan

  1. Open the recorder docker and export a video (Should add a default 5 seconds to end of clip)
  2. Try 0 seconds for "hold last frame option" and export (Should not add any frames at end of clip)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports