Skip to content

Fix overwriting inactive gradients

reinold rojas requested to merge reinoldrojas/krita:reinoldrojas/fix-overwriting-deleted-gradient into master

Before this commit if you tried to create a gradient using the name of one that was previously deleted you would get prompted to overwrite it. However the new gradient wouldn't get created even if you clicked yes. This commit makes the gradient actually get created.

Found on KA beta testing topic here

Test Plan

  1. Open the gradient widget and create a test gradient.
  2. Delete that gradient
  3. Create a new gradient with the same name
  4. The new gradient should now appear in the gradient list

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by reinold rojas

Merge request reports