Skip to content

Fix various textless button styling inconsistencies

R. B. requested to merge tomtomtom/krita:tomtomtom/flattencolorimageicon into master

Currently in Krita 5, some textless buttons will be flat, some textless buttons won't be flat, and some flat buttons will not raise on hover, sometimes within the same docker/interface. For example, see the current Animation Curves docker, which exhibits all three of those cases. To me, this causes confusion on what's activated and/or what's currently pressable.

This merge request fixes most of the inconsistencies by flattening whatever's not flat and autoraising whatever's not autoraised. (Also adds a seemingly missing horizontal spacer between the save button and delete button in the reference tool options.)

This merge request does not really attempt to touch "Open/Select Folder" buttons, "Lock/Unlock" buttons, 3x3 grid arrow buttons, or buttons in most popup windows, as I'm not sure if it's necessary to touch those. I also wanted to make the titlebar buttons autoraise, but I couldn't figure how to fix that.

TODO:

  • Fix button styling inconsistencies in various tool options

Test Plan

Hover over various buttons of various interfaces.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by R. B.

Merge request reports