Skip to content

Draft: [not for 5.0] 438426 Implement consent for remote images and prefer clipboard bitmaps

Amy spark requested to merge lsegovia/krita:work/amyspark/yet-more-5_0-fixes into master

This MR adds a consent flow before downloading an image. It also switches the priority from URLs only, to bitmaps and then URLs, when both are present in the system clipboard.

BUG: IS-438426

Test Plan

Build Krita. Copy and paste an image from Firefox. Check that there's no consent flow, and that the bitmap is instantly pasted. Repeat with a drag-and-drop-event. Perform the same steps with Chromium (preferably <95, since it only gives an URL). Check that the user is asked for consent before downloading the image.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Amy spark

Merge request reports