Skip to content

445179 Fix opengl es initialization for different formats

Sharaf Zaman requested to merge szaman/krita:bug-445179-crash-16bit-images into master
GLES 2 GLES 3 DesktopGL Windows (ANGLE)
16i GL_EXT_texture_storage GL_EXT_texture_norm16 GL_RGBA16 GL_EXT_texture_storage
16f GL_EXT_texture_storage GL_RGBA16F (!GL_EXT_texture_storage) GL_RGBA16F GL_EXT_texture_storage
32f GL_EXT_texture_storage GL_RGBA16F (!GL_EXT_texture_storage) GL_RGBA16F GL_EXT_texture_storage

BUG:445179

NOTE: I haven't tested the OpenGL ES 2 code paths, the initialized state for them is the same as it was previously.

Test Plan

This requires testing on windows, specifically with ANGLE renderer.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Amy spark

Merge request reports