Skip to content

Let Assistants, Guides and Grids be transformed alongside the layers of the image

Dmitry Kazakov requested to merge kazakov/transformable-decorations-bug-331789 into master

The patch actually fixes a 5 years old bug :) https://bugs.kde.org/show_bug.cgi?id=331789

Now when you transform or crop the image, assistants, guides and grids are also transformed.

Test Plan

  1. Create Guides, Assistants and Grids of all the kinds.
  2. Draw something on the image in the assistants' position to be able to track their position after the transformation.
  3. Use Scale/Resize/Rotate/Mirror actions from the "Image" menu.
  4. Use Crop Tool
  5. Try to Undo/Redo
  6. Try to save/load/duplicate the image and transform it again, assistants should still transform.

The assistants, guides and grids should be transformed in expected way :)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports