Skip to content

443074 Assorted fixes for pre release

Amy spark requested to merge lsegovia/krita:work/amyspark/5_0-fixes into master

Fixes a longstanding bug with preset overwriting, and two others I found during testing of the first fix.

BUG: 443074

Test Plan

Build Krita, overwrite a resource, close Krita and then delete the resource's backing file from disk.

Then reopen Krita and verify the resource is still usable.

As for the dialogs, check that on attempting to overwrite a SeExpr or brush preset, the correct animations are shown. Windows in particular uses an expand/collapse animation.

Also check that MyPaint brushes thumbnails are correctly loaded.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

/cc @tymond

Merge request reports