Skip to content

Fix detection of OpenEXR < 3.0.0

Mathias Wein requested to merge (removed):cmake_exr_fix into master

Disclaimer: I'm terrible when it comes to CMake build files... 😝

Apparently there was a whole code block missing in the code branch for EXR < 3.0.0. I took the original ECM as reference and added the missing library bits, although I'm not sure we actually need IlmImfUtil, because pkg-config --libs OpenEXR does not include it here for 2.3.0. But the lib is packaged on Ubuntu 20.04

This patch applies only to master, due to this commit: 7699e8a1

Test Plan

Compile Krita on a platform using pkg-config with OpenEXR < 3.0.0, I guess.

I don't know which version(s) ship their own cmake find module, if any, mine obviously doesn't.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Mathias Wein

Merge request reports