Skip to content

Return zero pointer if document can't be opened

Artem Burjachenko requested to merge (removed):change-open-document into master

On fail in Krita::openDocument return 0, simmilar to Krita::createDocument Add nullcheck into Window::addView in order to not segfault if document was not opened

Maybe related to bug 419093

Test Plan

Run script, it will show error message box that file not found and do nothing

from krita import *

doc = Application.openDocument("Wrong Path")
window = Application.activeWindow()
view = window.addView(doc) # Resulted in krita crash before
window.showView(view)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports