Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 79
    • Merge requests 79
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1199

Make eraser snapping optional

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Tom Tom requested to merge tomtomtom/krita:tomtomtom/disableerasersnapping into master Dec 05, 2021
  • Overview 3
  • Commits 3
  • Pipelines 8
  • Changes 6

In my opinion, snapping to assistants is pretty tiresome due to the fact that erasers also snap. This commit makes it so that eraser snapping is optional and defaults to off. This commit adds new strings.

Test Plan

Test if regular brushes properly snap regardless of the option. Test if erasers properly snap with Eraser Snapping is enabled. Test if erasers don't snap if Eraser Snapping is disabled.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited Dec 05, 2021 by Tom Tom
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tomtomtom/disableerasersnapping