Skip to content

Reverse functionality of aspectButton and clarify its usage

R. B. requested to merge tomtomtom/krita:tomtomtom/useprintsize into master


This commit reverses the functionality of the "Use same aspect as pixels" button and changes its tooltip to "Map the displayed canvas size between pixel size or print size" instead. With the reversed functionality, it now defaults to unchecked, so there should be no difference in the default aspect or view.

I intended to include a bit to the tooltip that would denote the document's DPI, but it doesn't seem like the widget is allowed access to the view manager...

This commit adds new strings.

Test Plan

Confirm that there's no difference in the default zoom level, aspect, or view of a new document. Confirm that clicking the button properly changes the aspect.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by R. B.

Merge request reports