Skip to content

Make toolbox use vertical title when in horizontal orientation

Alvin Wong requested to merge alvinwong/krita:alvin/toolbox-vertical-title into master

Make it so that the toolbox will switch to a vertical title bar when its layout is horizontal. This mainly saves space when docked top/bottom (e.g. in the Animation workspace):

1639234633763

Note: This MR does not update the built-in Animation workspace to account for the space reduction. Perhaps @emmetoneill can help remake the workspace?

I think this can go into 5.0. IMO this is a small tweak with great usability improvement that is worth backporting, and the risk of this breaking things is low.

Test Plan

Resize the toolbox so that it switch to the horizontal layout, and check that the title bar has changed to vertical.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • n/a I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports