Skip to content

Port preset history to use the resource model more.

Wolthera van Hövell requested to merge work/wolthera/bug-446796 into krita/5.0

This means the presets are pulled from the resource model, as well, items are updated based on signals from the resource model.

So the presets stay up to date and are deleted from the list if they have been deactivated.

BUG:IS-446796

Lynx3d, I've set you as reviewer because you did some significant work in this docker. @eoinoneill , the solution here might be helpful for handling the workspace-list updates.

Test Plan

  1. Make a new preset.
  2. Use it, so it shows in the docker.
  3. Edit the preset, change it's name, or change the icon.
  4. Confirm the preset is changed in the docker.
  5. Remove preset.
  6. Confirm the preset is removed from the docker.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • [N/A] I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports