Skip to content

447293 G'MIC bug fixes

Amy spark requested to merge lsegovia/krita:work/amyspark/gmic into master

This MR fixes blending modes being left unapplied for G'MIC-emitted new layers. It also fixes a typo in the Krita->G'MIC layer naming step, back when I implemented the layer metadata formatting; this caused the metadata to not be sent with the images.

Test Plan

Build Krita and its plugins. Launch G'MIC with an image, run the Deformations/Drop Water filter, and check that layers are returned as follows:

imagen

where "Fondo" is the source layer's name. Also check that the layers have the following properties:

  • [gradient]: Grain Merge mode
  • [refraction]: Normal mode
  • [shadow]: Normal mode, 50% opacity
  • [specular spots]: Normal mode, 100% opacity

Finally, the result should look like this:

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports