Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Bugzilla
    • Bugzilla
  • Merge requests 73
    • Merge requests 73
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1262

445179 Fix OpenGL ES initialization for OCIO pipeline too

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Amy spark requested to merge lsegovia/krita:work/amyspark/445179 into master Dec 28, 2021
  • Overview 9
  • Commits 2
  • Pipelines 5
  • Changes 8

This MR backports the GLES surface initialization changes for Android to the OCIO-backed canvas.

CCBUG: 445179

Test Plan

Build Krita with OCIO on an OpenGL ES system. (Preferably Android, though a desktop platform with Qt built with -opengl es2 will suffice too.)

Check that all bit depths we support work out of the box.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited Jan 05, 2022 by Amy spark
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/amyspark/445179