Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Bugzilla
    • Bugzilla
  • Merge requests 72
    • Merge requests 72
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1268

Fix plugin weighting and restore WebP fallback

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Amy spark requested to merge lsegovia/krita:work/amyspark/webp-fallback into master Dec 30, 2021
  • Overview 3
  • Commits 2
  • Pipelines 2
  • Changes 39

This MR restores the WebP impex functionality to the QImageIO plugin. This is done with a higher X-KDE-Weight for the libwebp plugin, and through the restoration of the mimetypes and extensions to QImageIO.

However, before this MR, all X-KDE-Weight values would be defined as integers and parsed as strings, resulting in a value of 0 for all plugins.

This MR fixes both issues.

Test Plan

Build Krita both with and without libwebp. Ensure that WebP images can be opened and saved at all times.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/amyspark/webp-fallback