Skip to content

Fix bundling AppImageUpdate into appimages

Anna Medonosová requested to merge amedonosova/krita:amedonosova/fix-appimage-updating into master

Commit de2315ef added the check to disable embedding the AppImageUpdate script when CHANNEL is not manually set from the command line. However, this breaks all the Plus and Release builds on the Binary Factory (which use CHANNEL autodetection from the source code).

AppImageUpdate is available only for amd64 at this moment.

BUG:446757

Test Plan

Build the appimage in the docker environment, extract the appimage and check for the AppImageUpdate file.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports