Skip to content

Factor out common functionality of the freehand selection tool

Deif Lou requested to merge deiflou/krita:deiflou/KisToolOutlineBase into master

NOTE: This MR is in conflict with !1299 (merged) so review one and once that is merged I'll change the other.

This takes the generic code of the freehand selection tool and puts it on a new class named KisToolOutlineBase, similar to how KisToolRectangleBase and others do. This way the code can be reused in other places.

I need this for the enclose and fill tool I'm making, so this MR is made in part to reduce the amount of code to review when that comes out.

Also a bug present in KisToolSelectBase was fixed.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Deif Lou

Merge request reports