Skip to content

Assorted fixes for the Color Space Selector

Amy spark requested to merge lsegovia/krita:work/amyspark/colorspace-profiler-layout-update into master

This MR implements the following:

  • Use proper widget margin for the whole widget
  • Replace grid layout for vertical + a grid for the middle contents
  • Correct a missing space in the lbl_descriptionwidget text
  • Group "Profile" and its picker, so that it's correctly (accessibly) labeled
  • Move all profile properties to the namesake group
  • Display the ICC profile's manufacturer field, if available

Additionally, it fixes an uncontrolled HTML markup injection vulnerability in the rendering of various profile properties.

Before After
Captura_de_pantalla_2022-02-01_235835 Captura_de_pantalla_2022-02-01_235832

Test Plan

Build Krita. Open it, choose "New Document" and select "Color Space Browser". Check that all profiles you have are rendered correctly.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports