Skip to content

Extract OpenGL rendering code from KisOpenGLCanvas2 into KisOpenGLCanvasRenderer

Alvin Wong requested to merge alvinwong/krita:alvin/glcanvas-split into master

This moves the OpenGL canvas rendering code into a new class KisOpenGLCanvasRenderer. The aim is to allow the code to be reused by another canvas implementation, for example one based on QtQuick2/QML.

Just to be clear, I don't expect the code to already work with QtQuick2 without further modifications.

I used some tricks to preserve the git blame history of the new file. Rebasing must be done manually with care.

Test Plan

(Tell us how to test the changes you made.)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports