Skip to content

Fix issue with Mypaint presets when Slow Tracking interacts with Stabilizer

David Revoy requested to merge work/deevad/bug-447562_Mypaint-slow-tracking-interacts-with-stabilizer into master

I switched the "Slow Tracking" value of two Mypaint presets to 0.0.

I did that, because this change fixes a bug when "Slow Tracking" of c)Pencil_2b_(mypaint) and d)_Ink_pen_(mypaint)) interacts with Krita stabilisation. The interaction causes bad polygonal strokes on the canvas, example:

7ITpmqo
Picture made by Jesus, the bug reporter. It shows polygonal effect when Stabilisation is activated on the two Mypaint presets.

By removing 'Slow Tracking' (switching the value to 0), the presets now delegates fully the stabilisation to Krita and it prevents the polygonal lines to appear. It was tested with success by the reporter on the bug report: https://bugs.kde.org/show_bug.cgi?id=447562

Test Plan

  1. Select the brush c)Pencil_2b_(mypaint) or d)_Ink_pen_(mypaint)
  2. In Tool Option, set the smoothing to a stabilizer.
  3. Draw strokes
  4. Result: lines should be smooth (no polygonal stroke) and smoothing strenght should depends only about Krita stabilizer options.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports