Skip to content

Add configurability to Touch Gestures

Sharaf Zaman requested to merge szaman/krita:touch-gestures into master

Test Plan

  1. (Desktop) Try to install the profile available in share/krita/input (I didn't bump the PROFILE_VERSION, because the previous versions are still compatible with this version).

  2. Once the gestures are added in the Canvas Input Settings, try to perform the gestures in accordance with their corresponding action.

    Note: If the gestures don't work properly, check if there is a conflict. If there isn't, it has to be a bug.

  3. Some things to test when trying to perform gestures:

    a. Try rapidly

    b. Try slowly

    c. Raising single, multiple fingers

    d. Adding single, multiple fingers

    e. Invoking a popup action (like popup palette with a gesture)

  4. Check if the Canvas Input Settings dialog shows "Gesture" Type and things work as configured.

  5. Verify on MacOS if things are the way they were before with trackpad gestures, with only the addition of the gesture being visible in Canvas Input Settings dialog.

For Android testing APK (the packageId is org.krita.debug and signed with my key, so no need to uninstall/sign anything): https://drive.google.com/file/d/13VgBT7K2XvUh0FUqoWpya4629ZzwYIiz/view?usp=sharing

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports