Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Bugzilla
    • Bugzilla
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • Graphics
  • KritaKrita
  • Merge requests
  • !1343

Open
Created Feb 20, 2022 by Srirupa Datta@srirupaContributor3 of 6 tasks completed3/6 tasks
  • Report abuse
Report abuse

Draft: Add Perspective Ellipse Assistant Tool

  • Overview 36
  • Commits 27
  • Pipelines 8
  • Changes 10

This merge request is incomplete, needs review.

The following MR contains code required to add a Perspective Ellipse Assistant Tool in Krita and the project is under SoK'22.

As of now, I have created the four cornered convex quadrilateral for the Perspective Ellipse Assistant Tool by reusing the code from Perspective Assistant Tool.

I have added 2 new files, namely:

  1. PerspectiveEllipseAssistant.cc
  2. PerspectiveEllipseAssistant.h

And modified 2 files:

  1. CMakeLists.txt
  2. assistant_tool.cc

This is how the tool looks currently.

tool

UPDATE:

The tool now looks like this.

tool2

FEATURE: 405643

Test Plan

  • Run Krita.
  • Select the Assistant Tool Option.
  • From the drop down menu in the Tools Option Docker, select Perspective Ellipse.
  • Draw a quadrilateral on the canvas, the four corners are adjustable. The quadrilateral has an inscribed ellipse too!

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited Mar 03, 2022 by Srirupa Datta
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: Add-perspective-ellipse-assistant-tool