Skip to content

Make fill tool produce regions with minimal size when a selection is used

Deif Lou requested to merge deiflou/krita:deiflou/bug415439 into master

Fix for bug 415439

It seems that in the fill tool the resulting area filled is the size of the union between the rects of the floodfill mask and the current selection under the following conditions:

  • there is a selection
  • the fast mode is not used

I think this produced more pixels than needed when bitblt was used and if the filling is performed in an empty layer the thumbnail and memory in the statusbar reflect that fact.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports