Skip to content

Restore distutils support hack for non-UCRT MinGW

Amy spark requested to merge lsegovia/krita:work/amyspark/fix-mingw into master

This takes advantage of setuptools's _distutils_system_mod hack to override CygwinCCompiler. This is because since we set it to use a vendored copy, @alvinwong's override ends up targeting the "original" module (setuptools._distutils.cygwinccompiler) instead of the "real" module (setuptools.distutils.cygwinccompiler, without the underscore). The vendored copy does an importlib hack to overwrite the system module, which made our override unworkable.

This partially reverts commit d1ac50ae.

Test Plan

Build Krita deps with our MinGW CI toolchain.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports