Skip to content

Draft: [Proof of concept] Tool options toolbar

Deif Lou requested to merge deiflou/krita:deiflou/tool_options_toolbar into master

This MR adds a new way of showing the tool options, in a toolbar of its own.

The idea is to show the approach and start a discussion about if it is worth it.

At the moment it only shows the tool options if the tool options widget derives from the KisOptionCollectionWidget I introduced in the fill tool options revamp, since it is made to be able to be layout horizontally with a simple setOrientation line.

If this MR is considered valuable, I can try to adapt all other tool option widgets, making them more consistent and easy to port to a potential tool options toolbar.

A video showing the features:
https://www.youtube.com/watch?v=M-fULZqjfCI

Test Plan

  • Open Krita
  • Go to settings->Configure Krita...->General->Tools and select Tool Options Toolbar under Tool Options Location
  • Restart Krita
  • Create/open a document
  • Select the fill tool
  • Play with the tool options in the new toolbar
  • Go to Settings->Toolbars Shown and select and unselect Tool Options to see that everything works ok
  • Move the toolbar and dock it to other places (only top and bottom are allowed)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports