Skip to content

Make Sharpness option's outline alignment behavior optional

R. B. requested to merge tomtomtom/krita:tomtomtom/optionalaligntopixels into master

Sometime during the Krita 4 timeline, there was a change where the Sharpness option now forces the brush preview outline to conform to the pixel grid. This kind of behavior is not necessarily preferable to every user/workflow, as I've seen at least a couple users speak against it, so I made this behavior optional and saved to the brush.

By default, this behavior is disabled.

outline

Test Plan

Observe the snappiness of the brush preview outline when:

  • Sharpness option is turned off and the pixel alignment is turned off
  • Sharpness option is turned off, and the pixel alignment is turned on
  • Sharpness option is turned on, and the pixel alignment is turned off
  • Sharpness option is turned on, and the pixel alignment is turned on

Also save and test brushes with the above configurations in mind.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by R. B.

Merge request reports