Skip to content

452856 452898 Paste format handling fixes

Amy spark requested to merge lsegovia/krita:work/amyspark/fix-paste-again into master

BUG: 452856

BUG: 452898

Test Plan

Build Krita and check that pastes from Windows Explorer/Firefox and Chrome <96 can be successfully pasted as reference images.

Questions

  • Currently, the Image Reference tool bypasses the whole consent/choice flow by targeting the clipboard itself (see KisReferenceImage::fromClipboard as opposed to KisReferenceImage::fromPaintDevice, which is what drag&drop uses).
    • Is it OK to have a consistent flow across tools @dkazakov?

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Amy spark

Merge request reports