Skip to content

Adds HSV color picker to the Specific Color Selector

Sam Linnfer requested to merge lllf/krita:lllf/add-hsv-color-picker into master

Adds a long requested HSV Color Selector. Resolves: BUG:397413

Screenshot_20220428_143719 Screenshot_20220428_143656

Test Plan

  1. Create a new document
  2. Open the Specific Color Selector panel
  3. A new radio button group "HSV/RGB" should be visible
  4. Clicking on "HSV" will change sliders to HSV
  5. Manipulating HSV sliders will let you pick colors in HSV.
  6. Changing to a non-RGB colorspace will automatically switch back to "RGB" and hide the radio button group

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Sam Linnfer

Merge request reports