Skip to content

Fix crash on undo after importing assistant set

Agata Cacko requested to merge tymond/krita:tiar/fix_crash_on_undo_on_import_assistants into master

Fix crash on undo after importing assistant set

Before this commit, importing assistant set was not undoable, which broke internal state of the tool, which led to crash. This commit makes importing the assistant set undoable, preventing the crash.

BUG:455584

https://bugs.kde.org/show_bug.cgi?id=455584

Test Plan

(Taken from the bug report) 1.Create a ruler 2.Save ruler file locally（.paintingassistant） 3.Click the icon to delete the ruler (do not "delete all") 4.Import the ruler file 5.undo (Krita shouldn't crash, just undo)

Note: importing the assistant set is treated as one action, so if the user undoes it, all of them get deleted, and when they redo, all of them come back. That's expected.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports