Skip to content

Enable building Tools tests on MSVC and macOS

Amy spark requested to merge lsegovia/krita:work/amyspark/tiar-perspective-assistant-test into master

This MR demos how we could do in order to make the tools' tests buildable for MSVC and macOS. By hollowing the loadable module, and making its code a static library, we can now link the tests statically against the latter.

This is not needed on MinGW and on Linux because in those cases, the symbols are always exported even though the plugin is a loadable library:

imagen

/cc @dkazakov @tymond

Test Plan

Build Krita with BUILD_TESTING set to ON. Run the tests.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Amy spark

Merge request reports