Skip to content

Assistants improvements part 3 (07.07.2022)

Agata Cacko requested to merge tymond/krita:tiar/assistants_improvements_part3_07_07_2022 into master
  1. Change delete assistant icon from cancel to trashcan
  2. Add lock icon.
  3. Let Shift in assist. snap to 15 instead of 90degrees
  4. Save assistant editor widget position offset to file

Changing delete assistant icon to trashcan:

Adding lock icon:

Test Plan

  1. Create a new document.
  2. Create a new assistant, while creating use Shift + dragging to see the angles that it snaps to.
  3. After creation, edit the handles with Shift to see it still works.
  4. Move the editor widget position to some other place.
  5. Lock the assistant.
  6. Check if you can edit the assistant in any way.
  7. Save and reopen to see if lock state and the editor widget position are saved to .kra file (they should be).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Agata Cacko

Merge request reports