Skip to content

Set maximum width to the blending mode combobox on the toolbar

Agata Cacko requested to merge tymond/krita:tiar/squeeze_blending_modes_combobox_on_toolbar into master

Before this commit, the blending mode combobox on the toolbar was as wide as the widest item inside. It isn't needed, because when unfolded, it shows all the items in a wider rectangle which is wide enough for the widest item.

This commit sets the maximum width for the combobox, so it takes less space on the toolbar than before.

If the user chooses a very wide item, the combobox will just cut of the end of the item (and if there are multiple blending modes that start with the same string, and the ending is cut, the user can just click on the combobox and will see the full text).

Requested here: https://krita-artists.org/t/make-blending-modes-combobox-smaller/43779/2 and sounded like a good (and very easy/short) idea.

Before: Before After: After

Test Plan

Open Krita, make sure the blending modes combobox is smaller than before (takes less space), and that other blending modes comboboxes work just as usual. Set up different blending modes to see if the user can comfortably use it even with a shorter combobox.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Agata Cacko

Merge request reports