Skip to content

Draft: Improved snapping in perspective-based assistants

Agata Cacko requested to merge tymond/krita:tiar/assistants_improvements_part4_04_08_2022 into master

The idea is that every vanishing point should snap to other assistant's vanishing points and of course the vanishing point assistant, the same goes for horizons snapping to each other and vanishing points snapping to horizons.

Test Plan

VPs:

- VP 2pp Perspective Perspective Ellipse
VP - - - -
2pp - - - -
Perspective - - - -
Perspective Ellipse - - - -

Horizons:

- 2 VP 2pp Perspective Perspective Ellipse
2 VP - - - -
2pp - - - -
Perspective - - - -
Perspective Ellipse - - - -

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports