Skip to content

KoResourcePaths: fix regression when enumerating resource directories

Amy spark requested to merge lsegovia/krita:work/amyspark/fix-unc into master

Before commit 985ba60e, all checks for extra resource directories were made via QString::split with SkipEmptyParts. This behaviour was removed, which means that if EXTRA_RESOURCE_VARIABLES has an empty value, the resource loader will try to hit an UNC network path for every non-empty folder.

CCBUG: 457348

BUG: 458188

Test Plan

Build Krita. Check that, on Windows at least, there are no exceptions thrown from inside QDir as shown in the bug report.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports