Skip to content

[kritamultiarch] Color space traits optimizations

Amy spark requested to merge lsegovia/krita:work/amyspark/kocolorspacetraits-optimizations into master

As part of the kritamultiarch refactor, I noticed some missed optimizations in the disassembly of kritapigment.

They come from Qt's lazy shallow copy overhead, which I remove in this MR along with fixing proper constness for the pixel accessors.

This will enable autovectorization for the trait functions.

Test Plan

Build Krita and run tests.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports