Skip to content

458546 Fix Move Tool refactor

Amy spark requested to merge lsegovia/krita:work/amyspark/458546-dmitry-move-tool-refactor-fix into master

The nested recursion over m_nodes means that the strategies will be executed at least twice for each node. This is inconsistent with the rest of commit 4a427ee6 of @dkazakov 's, so let's fix that.

BUG: 458546

Test Plan

Follow Halla's repro in the bug. Two or more layers need to be selected in order to cause the crash, due to the quadratic recursion.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports