Skip to content

Make MyPaint eraser use the proper brush settings

Carsten Hartenfels requested to merge hartenfels/krita:mypainteraser into master

When enabling eraser mode, Krita will use the default MyPaint brush settings instead of the ones the user has actually selected. This is unlike MyPaint, GIMP and Drawpile do it, which use the selected brush to erase.

eraseissue

This is due to a setting that enables this odd behavior, which is not actually exposed in the user interface, meaning there's no way to turn it off. This commit outright removes that setting and makes Krita behave properly: use the brush that's selected and erase with it, don't switch to something else behind the scenes.

erasefixed

That kind of setting isn't available in any other software, so I didn't see a point of keeping it. If the user wants to erase with a round opacity brush, they can switch to one themselves.

Test Plan

Select a MyPaint brush, toggle eraser mode on and erase something. Observe that erasing happens with the selected MyPaint brush settings now.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports