Skip to content

Set the main window's dock-widget corners when locking a docker

Mike Will requested to merge myqwil/krita:corner-lock into master

Set corners in favor of the docker being locked, but only if the adjacent dock-widget area is empty, or if it doesn't alter the current layout.

Test Plan

  • Place a docker in the bottom dock-widget area. You'll notice that it spans the entire width of Krita's window, and in the process it also squishes the left and right dock-widget areas.
  • Float the docker that you just docked, find a different docker that resides in either the left or right dock-widget area, and lock it.
  • Place the floating docker back into the bottom dock-widget area. You'll see that it no longer spans the window's entire width and instead stops at the dock-widget area of the locked docker.

I made a video of a test case scenario to help better illustrate how this feature may be useful.

https://replay.dropbox.com/share/0pB2k8b8Du6HfJzK

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports