Skip to content

Fix dab inaccuracy of Sharpness brushes when outline preview snapping is disabled

R. B. requested to merge tomtomtom/krita:tomtomtom/fixsharpness into master

BUG:458361

This MR mostly reverts the relevant commit from !1405 (4c639ee9) that spawned this issue. I'm not sure if the alignOutlineToPixels() check can be easily moved within KisPressureSharpnessOption::apply, as originally requested in that MR, without causing behavioral changes in dabs, but I might not understand the code enough.

Test Plan

Make sure sharpness brushes don't change in dab behavior at all regardless if "Align brush outline preview to pixel grid" is checked or not. The option should only affect visuals of the preview.

Make sure the dab behavior conforms to the dab behavior of 5.0.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by R. B.

Merge request reports