Skip to content

Fix Foreground-to-Background color switching of vector objects

Sharaf Zaman requested to merge szaman/krita:bug-458913-fix-vector-objects-fill into master

If the fg-bg color was swapped rapidly enough, the resulting shape would often have the same color (rather than it being swapped).

The reason for this being resourceManager would send us signal to change both fg and bg, but if the delay between them is less than colorChangedCompressor's timeout, the latter signal would be ignored. Which would prevent the swapping from happening. The proper solutions seem to be to either have a compressor at the source (which there does seem to be) or have separate channel (ie different timers) for different resources (bg, fg and gradient in this case).

Test Plan

BUG:458913

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Sharaf Zaman

Merge request reports