Skip to content

Fix regression when using KisKisMergeLabeledLayersCommand

Deif Lou requested to merge deiflou/krita:deiflou/color_labeled_layer_fill_frames into master

From 5.1 on KisMergeLabeledLayersCommand seemed to always use the first frame to create the merged reference device.

I made sure the issue was not introduced by my changes. I replaced the fill tool, FillProcessingVisitor, KisFillPainter and KisMergeLabeledLayersCommand with pre-5.1 versions and the issue was still there. Then I began messing with the KisMergeLabeledLayersCommand since the "current layer" and "all layers" reference modes were behaving ok.

The solution I found was changing the current time in the temporary image used by KisMergeLabeledLayersCommand to the same as the original image. But I don't know what really changed on 5.1 and if there is a better solution.

BUG:459013 BUG:458867

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Deif Lou

Merge request reports