Skip to content

Fix several theme related issues

Deif Lou requested to merge deiflou/krita:deiflou/fix_theme_issues into master

This MR fixes some issues that happen updating the ui when the theme is changed:

  • Changes the order in which the icon cache if cleared. Now it is cleared before the new palette is set on the app. This way the widgets that have no way of being notified of theme changes via signals can react by intercepting the palette change. The icon cache needs to be already cleared at that point so that the updated icons can be loaded when the palette changes.
  • Fixed some weird issue in kis_icon_utils. Some icons were not properly updated when changing the theme (brush tool icon, save icon, and others).
  • Update the palette of the widgets on the toolbars.
  • Changes to properly update:
    • icons on the gradient widgets
    • gallery icon on the filter and fill layer dialogs
    • icons on the layer properties dialog (properties checkboxes)
    • icons on the resource item chooser
    • preview in the brush editor

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports