Skip to content

Replace Text Layout with Raqm and Freetype, Unittest edition.

Wolthera van Hövell requested to merge woltherav/krita:wolthera/text-refactor-unittests into master

Continued from !1403 (closed) , this MR focuses on replacing all of the text layout code with Raqm, FreeType and Harfbuzz.

Previous MR had to be closed because it was getting too big. This MR will focus on getting everything unit tested, buildable and to allow for performance improvements.

Note: Please don't do performance improvements until the unit-tests are done, text is super fiddly.

I'm keeping tracks of tasks here: %Text Tool in woltherav/krita.

BUG:460261, BUG:392473, BUG:439908, BUG:395808, BUG:447714

CCBUG:447533 (needs windows device), CCBUG:426607 (Unsure if css supports this at all), CCBUG:454845 (we have vertical text now, but the request is in specific for an option, which means this will need to wait for the text-tool rework to truly be fixed.

Test Plan

Build and use the text-tool. For the majority of features, you'll need to use the svg editor directly.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Wolthera van Hövell

Merge request reports