Skip to content

Tweaks/fixes to some tools

Deif Lou requested to merge deiflou/krita:deiflou/various_tool_tweaks into master

This MR applies some changes to some tools:

  • Fix incorrect painting of outline in KisToolOutlineBase - It didn't update correctly when zooming while the shape was being made
  • Add snapping to polygonal mode of KisToolOutlineBase - It now can snap when the polyline mode is active
  • Allow KisToolPath to use the popup palette - for some reason the path tool couldn't show the popup palette when the shape was not being made
  • Make KisToolSelectBase work nicely with popup widgets and menus - Shouldn't have any visual effect, but now it can delegate in the specific tool, in case those can/want show some widget/menu while the selection is being made
  • Add "right click to undo last point" to KisToolPolylineBase - mimic the behavior of the path tool to undo the last point
  • Add "right click to undo last point" to KisToolOutlineBase when in polyline mode - mimic the behavior of the path tool to undo the last point when the polyline mode is active
  • Fix issue in the path selection tool - prevent KoCreatePathTool from ending the shape when there were no actual shape. This produced a bug in the path selection tool where the endShape function was called in the middle of creating the new selection so it was mixed with the current one with the incorrect selection action.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Deif Lou

Merge request reports