Skip to content

macOS Clean up cmaket build test configurations

Ivan Yossi requested to merge ivany/krita:better_reAddTest into master

This fixes the hacky way of running tests on macOS, and makes it easier to keep the state of test in a single list just as before. This is possible now since commit b1681ede added a special case for tests. This ensures no special care is needed when adding tests as they will be built correctly on macos.

The patch does:

  • Removes all GUI compilation flag for test not needing it (98% of them)
  • Add each target name to a KRITA_TESTS_TARGET and call macos_fix_rpath to that list, thus removing the call from almost every CMakeLists.txt
  • Repair build of plugins-dockers-layerdocker-TestNodeView uncomment build and mark it as broken_test
  • Repair compilation of plugins-tooltransform-test_animated_transform_parameters using the same strategy as 8cfbf52e
  • Enables all tests on macos (since most run without issues) -> terminal output from ninja test run

For running tests on macos it is only needed to set KIS_TEST_PREFIX_PATH environment variable to point at the install directory.

Merge request reports

Loading